Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

There is no OSGI bundle for jgroups #1

Closed
wants to merge 1 commit into from

Conversation

flashboss
Copy link
Contributor

The actual maven configuration doesn't permit to create a OSGI bundle. I'm testing it with felix. I updated the pom.xml so if you use mvn install you get a OSGI bundle. Remains to configure it for ant

…} instead of ${pom.version} because it is deprecated. We need to ignore the dependency with bsh to install jgroups in a osgi repository. The maven 'Optional' tag doesn't work in maven-bundle-plugin
@belaban
Copy link
Owner

belaban commented Nov 23, 2010

OK, I have merged this change into master.
However, packaging is still "jar": if I change this to "bundle", JGroups/bin/release_to_nexus.sh releases the JGroups JAR as bundle to Nexus, and not as JAR.

If you have a fix for release_to_nexus.sh, I'm willing to change packaging to "bundle".

@belaban
Copy link
Owner

belaban commented Nov 23, 2010

OK, I changed pom.xml and set bundle.

I also changed the release_to_xxx.sh scripts and added an explict (and overriding) -Dpackaging=jar system property. This works now

@flashboss
Copy link
Contributor Author

very good...it should be enough

@belaban
Copy link
Owner

belaban commented Nov 24, 2010

Excellent, let me know if this works for you !
Cheers,

@flashboss
Copy link
Contributor Author

how I download the last sources? sorry, github is new for me

@belaban
Copy link
Owner

belaban commented Nov 25, 2010

You can do a git clone URL, where the URL is shown on github.com/belaban/JGroups, or download a ZIP from https://github.com/belaban/JGroups/archives/master

@flashboss
Copy link
Contributor Author

Downloaded. If I use 'mvn clean install' I see the correct MANIFEST.MF but if I use the command './build.sh clean jgroups.jar' I see the old MANIFEST without the OSGI properties

@belaban
Copy link
Owner

belaban commented Nov 25, 2010

That's intended. I want the ant build to generate regular JARs, whereas the mvn build generates OSGI bundles. Or do you want the ant build to generate a JAR with the OSGI manifest inside ?

If you find a way to do this with ant, go ahead and send me the patch !

@flashboss
Copy link
Contributor Author

I think the important thing is that everyone would use jgroups in OSGI can download it simply from binaries without download the sources and compile it. Can it be done? If no I will be happy to continue

@flashboss
Copy link
Contributor Author

ok ..it's under work

@flashboss
Copy link
Contributor Author

There are three solutions to use the new manifest with ant:

1- we copy the new manifest generated by ant in conf/manifest.mf file. We have to care attenction when the dependencies or the packages changes, in that case we have to re-copy it

2 - we can use in the build.xml the manifest generated by ant in target/classes/META-INF/MANIFEST.MF. We are forced to launch a 'mvn package' before starting ant but we can add the launch in the build.sh before the ant execution

3 - move all from ant to maven

@belaban
Copy link
Owner

belaban commented Nov 26, 2010

#1: -1
#2 might as well use mvn install to generate the JARs
#3: not an option currently

@flashboss
Copy link
Contributor Author

ok for 2 ....you can try it...
I changed the paths for manifest.mf pointing to target/classes and removed the overwrite using maven-jar-plugin configuration. To use maven before ant it is enough add a 'mvn install' in build.sh before the java start. Anyhow we are forced to install maven to use build.sh

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants