[Nexus 1.2.0] Always hook set registry

[filmakarov]

If called by EP, setRegistry won't be not hooked, which means owner could update the registry and make the claims revert for the solvers if Nexus is used with resource locks

---

PR-Codex overview

This PR modifies the setRegistry function in the Nexus.sol contract to remove the access control modifier and enforce that only the contract itself can call the function.

Detailed summary

• Removed the onlyEntryPointOrSelf modifier from the setRegistry function.
• Added a require statement to ensure that msg.sender is the contract itself.
• The function still configures the registry using _configureRegistry.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

[github-actions]

🤖 Slither Analysis Report 🔎

Slither report

# Slither report

THIS CHECKLIST IS NOT COMPLETE. Use --show-ignored-findings to show all the results.
Summary
🟡 - unused-return (2 results) (Medium)

• constable-states (2 results) (Optimization)

unused-return

🟡 Impact: Medium
🟡 Confidence: Medium

• ID-0
  ModuleManager._uninstallValidator(address,bytes) ignores return value by validator.excessivelySafeCall(gasleft()(),0,0,abi.encodeWithSelector(IModule.onUninstall.selector,disableModuleData))

base/ModuleManager.sol#L220-L229

• ID-1
  ModuleManager._uninstallExecutor(address,bytes) ignores return value by executor.excessivelySafeCall(gasleft()(),0,0,abi.encodeWithSelector(IModule.onUninstall.selector,disableModuleData))

base/ModuleManager.sol#L243-L247

constable-states

Impact: Optimization
🔴 Confidence: High

• ID-2
  RegistryAdapter.registry should be constant

base/RegistryAdapter.sol#L10

• ID-3
  RegistryFactory.threshold should be constant

factory/RegistryFactory.sol#L38

_This comment was automatically generated by the GitHub Actions workflow._

[openzeppelin-code]

[Nexus 1.2.0] Always hook set registry

Generated at commit: 9ac502fed1ae4cbe9cca2f6bad39512bd36b17be

🚨 Report Summary

	Severity Level	Results
Contracts	Critical High Medium Low Note Total	1 1 0 6 30 38

---

For more details view the full report in OpenZeppelin Code Inspector