Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Nexus 1.2.0] Native Composability Support #258

Merged

Conversation

filmakarov
Copy link
Collaborator

@filmakarov filmakarov commented Mar 17, 2025

Use Composability Base as dependency

@filmakarov filmakarov marked this pull request as draft March 17, 2025 15:37
Copy link

openzeppelin-code bot commented Mar 17, 2025

[Nexus 1.2.0] Native Composability Support

Generated at commit: 6e802dcc3b9441ce202452700f40cf9fb45f4a1d

🚨 Report Summary

Severity Level Results
Contracts Critical
High
Medium
Low
Note
Total
1
1
0
6
30
38

For more details view the full report in OpenZeppelin Code Inspector

@filmakarov filmakarov marked this pull request as ready for review March 18, 2025 11:23
Copy link

🤖 Slither Analysis Report 🔎

Slither report

# Slither report

THIS CHECKLIST IS NOT COMPLETE. Use --show-ignored-findings to show all the results.
Summary
🟡 - unused-return (2 results) (Medium)

unused-return

🟡 Impact: Medium
🟡 Confidence: Medium

base/ModuleManager.sol#L220-L229

base/ModuleManager.sol#L243-L247

constable-states

Impact: Optimization
🔴 Confidence: High

base/RegistryAdapter.sol#L10

factory/RegistryFactory.sol#L38

_This comment was automatically generated by the GitHub Actions workflow._

@filmakarov filmakarov merged commit f64bb68 into release/nexus-v1.2.0-ep-v0.7 Mar 20, 2025
5 of 9 checks passed
@filmakarov filmakarov deleted the feat/nexus-1.2.0-native-composability branch March 20, 2025 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant