[Nexus 1.2.0] Fix issues 4,5,6 Zenith #257
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR-Codex overview
This PR focuses on enhancing the
ModuleManager
contract by adding new pre-validation hooks and correcting a byte comparison in a conditional check.Detailed summary
PreValidationHookERC1271
andPreValidationHookERC4337
._uninstallPreValidationHook
function by removing a call toexcessivelySafeCall
.0xef01
to0xef0100
in the conditional check.