Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Nexus 1.2.0] Fix issues 4,5,6 Zenith #257

Merged
merged 2 commits into from
Mar 20, 2025

Conversation

filmakarov
Copy link
Collaborator

@filmakarov filmakarov commented Mar 17, 2025


PR-Codex overview

This PR focuses on enhancing the ModuleManager contract by adding new pre-validation hooks and correcting a byte comparison in a conditional check.

Detailed summary

  • Added documentation for new pre-validation hooks: PreValidationHookERC1271 and PreValidationHookERC4337.
  • Updated the _uninstallPreValidationHook function by removing a call to excessivelySafeCall.
  • Corrected the byte comparison from 0xef01 to 0xef0100 in the conditional check.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Copy link

[Nexus 1.2.0] Fix issues 4,5,6 Zenith

Generated at commit: 0d7b67248cd97c3019ee245d463faa69d501f21c

🚨 Report Summary

Severity Level Results
Contracts Critical
High
Medium
Low
Note
Total
1
1
0
6
30
38

For more details view the full report in OpenZeppelin Code Inspector

@filmakarov filmakarov merged commit 7d8621a into release/nexus-v1.2.0-ep-v0.7 Mar 20, 2025
4 of 9 checks passed
@filmakarov filmakarov deleted the fix/zenith-nexus-4-5-6 branch March 20, 2025 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant