Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix abyss-pe to pass N parameter as expected #487

Merged
merged 1 commit into from
Oct 18, 2024
Merged

Conversation

lcoombe
Copy link
Member

@lcoombe lcoombe commented Oct 18, 2024

  • N was not passed to DistanceEst as expected
    • When only PE reads specified, -n was propagated from the contig stage
    • When MP reads were specified, if a range was specified, this was passed to -n causing a failure (reported in DistanceEst: invalid option: `-n15-20' #486)
  • Solution here: Ensure that the scaffold parameters are properly passed to DistanceEst for both read inputs, using the lower number if a range is provided

Copy link
Member

@jwcodee jwcodee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

@lcoombe lcoombe merged commit 9ef1f4b into master Oct 18, 2024
13 checks passed
@lcoombe lcoombe deleted the distance_est_n branch October 18, 2024 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants