Add tmx_load_buffer_path() for loading with virtual paths #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
baylej
force-pushed
the
tmx_load_buffer_path
branch
from
d373be5 to
e1e9cd9
Compare
|
Can this be merged? |
|
Hi, Sure, but first I need to add functions with virtual paths to the other variants of tmx_load (using FD and Callback). I'll work on it soon. |
baylej
force-pushed
the
tmx_load_buffer_path
branch
2 times, most recently
from
c9f6c62 to
5c5aca6
Compare
|
Hi @RobLoach , I've slightly reworked your contribution, would you like to review my modifications before I squash and merge? |
Co-authored-by: baylej <[email protected]>
baylej
force-pushed
the
tmx_load_buffer_path
branch
from
5c5aca6 to
f88a433
Compare
|
Thanks for the work here, @baylej! Haven't had a chance to test fully yet, but looks great. When I get the time to update it in my system, I'll let you know how it works out 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change introduces a new function to allow loading a map buffer, while setting a virtual path for it. Allows for loading buffers, while controlling where its associated images are loaded from. Fixes #57