Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fallback mechanism if pkg-config fails #717

Merged
merged 2 commits into from
Feb 9, 2023
Merged

Add fallback mechanism if pkg-config fails #717

merged 2 commits into from
Feb 9, 2023

Conversation

babaric-dev
Copy link
Contributor

COMPLETIONSRC: path to sourced bash_completion

If pkg-config fails to get bash_completion script:

  • use brew on macOS
  • use PREFIX on Linux

babaric-dev and others added 2 commits February 9, 2023 09:37
`COMPLETIONSRC`: path to sourced `bash_completion`

If `pkg-config` fails to get `bash_completion` script:
- use `brew` on macOS
- use `PREFIX` on Linux
@skovhus skovhus enabled auto-merge February 9, 2023 08:37
Copy link
Collaborator

@skovhus skovhus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I'm surprised by the auto completions though. I usually end up with too many -- when testing this on Mac OS. But that is another issue. Does it work well for you (which editor)?

@skovhus skovhus merged commit 0b97b92 into bash-lsp:main Feb 9, 2023
akurtakov added a commit to akurtakov/shellwax that referenced this pull request Feb 24, 2023
Impovements in the LS:

- Support for bash options auto completions when using Brew or when
`pkg-config` fails, but bash completions are found in
`"${PREFIX:-/usr}/share/bash-completion/bash_completion"`
bash-lsp/bash-language-server#717

- Remove diagnostics for missing nodes that turns out to be unstable
(this was introduced in 4.5.3)
bash-lsp/bash-language-server#708

- Fix the ShellCheck code action feature that for some clients did not
return any code actions.
bash-lsp/bash-language-server#700

- Support parsing `: "${VARIABLE:="default"}"` as a variable definition
bash-lsp/bash-language-server#693

- Use sourcing info even if `includeAllWorkspaceSymbols` is true to
ensure that files not matching the `globPattern` (and therefore not part
of the background analysis) is still resolved based on source commands.
bash-lsp/bash-language-server#695

- Skip running ShellCheck for unsupported zsh files. We will still try
for files without a shebang and without a known file extension.
bash-lsp/bash-language-server#694

- Fix issue where some features would work as expected in case of a
syntax issue bash-lsp/bash-language-server#691

- Fixed `onReferences` to respect the `context.includeDeclaration` flag
bash-lsp/bash-language-server#688
- Removed unnecessary dependency `urijs`
bash-lsp/bash-language-server#688

- Include grouped variables and functions when finding global
declarations bash-lsp/bash-language-server#685
- Skip completions in the middle of a non word when the following
characters is not an empty list or whitespace.
bash-lsp/bash-language-server#684
- Remove infrequent and rather useless "Failed to parse" diagnostics
(and thereby the `HIGHLIGHT_PARSING_ERRORS` and `highlightParsingErrors`
configuration option) – the tree sitter parser is actually rather good
at error recovery. Note that these messages will now be shown in the
log. bash-lsp/bash-language-server#686

- Include 30 snippets for language constructs (e.g. `if`), builtins
(e.g. `test`), expansions (e.g. `[##]`), and external programs (e.g.
`sed`) bash-lsp/bash-language-server#683

- Improve source command parser and include diagnostics when parser
fails bash-lsp/bash-language-server#673
- Fix `onHover` bug where sourced symbols on the same line as a
reference would hide documentation
bash-lsp/bash-language-server#673
akurtakov added a commit to eclipse-shellwax/shellwax that referenced this pull request Feb 24, 2023
Impovements in the LS:

- Support for bash options auto completions when using Brew or when
`pkg-config` fails, but bash completions are found in
`"${PREFIX:-/usr}/share/bash-completion/bash_completion"`
bash-lsp/bash-language-server#717

- Remove diagnostics for missing nodes that turns out to be unstable
(this was introduced in 4.5.3)
bash-lsp/bash-language-server#708

- Fix the ShellCheck code action feature that for some clients did not
return any code actions.
bash-lsp/bash-language-server#700

- Support parsing `: "${VARIABLE:="default"}"` as a variable definition
bash-lsp/bash-language-server#693

- Use sourcing info even if `includeAllWorkspaceSymbols` is true to
ensure that files not matching the `globPattern` (and therefore not part
of the background analysis) is still resolved based on source commands.
bash-lsp/bash-language-server#695

- Skip running ShellCheck for unsupported zsh files. We will still try
for files without a shebang and without a known file extension.
bash-lsp/bash-language-server#694

- Fix issue where some features would work as expected in case of a
syntax issue bash-lsp/bash-language-server#691

- Fixed `onReferences` to respect the `context.includeDeclaration` flag
bash-lsp/bash-language-server#688
- Removed unnecessary dependency `urijs`
bash-lsp/bash-language-server#688

- Include grouped variables and functions when finding global
declarations bash-lsp/bash-language-server#685
- Skip completions in the middle of a non word when the following
characters is not an empty list or whitespace.
bash-lsp/bash-language-server#684
- Remove infrequent and rather useless "Failed to parse" diagnostics
(and thereby the `HIGHLIGHT_PARSING_ERRORS` and `highlightParsingErrors`
configuration option) – the tree sitter parser is actually rather good
at error recovery. Note that these messages will now be shown in the
log. bash-lsp/bash-language-server#686

- Include 30 snippets for language constructs (e.g. `if`), builtins
(e.g. `test`), expansions (e.g. `[##]`), and external programs (e.g.
`sed`) bash-lsp/bash-language-server#683

- Improve source command parser and include diagnostics when parser
fails bash-lsp/bash-language-server#673
- Fix `onHover` bug where sourced symbols on the same line as a
reference would hide documentation
bash-lsp/bash-language-server#673
@babaric-dev babaric-dev deleted the completionsrc branch March 4, 2023 09:27
@babaric-dev babaric-dev restored the completionsrc branch March 4, 2023 09:27
@babaric-dev babaric-dev deleted the completionsrc branch March 4, 2023 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants