Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Logger setup #669

Merged
merged 10 commits into from
Jan 10, 2023
Merged

Logger setup #669

merged 10 commits into from
Jan 10, 2023

Conversation

skovhus
Copy link
Collaborator

@skovhus skovhus commented Jan 9, 2023

This PR introduces a better logging setup:

  • centralize logging
  • make the logging output better including timestamp and log severity
  • make minimum log level configurable through environment variable BASH_IDE_LOG_LEVEL and through workspace configuration

Note that the environment variable should be used in combination with workspace configuration in order to ensure that the server starts with the right level (i.e. before workspace configuration is available).

Before

Screenshot 2023-01-09 at 14 04 04

After

Screenshot 2023-01-09 at 14 07 21

(slightly cluttered as vscode mixes up trace logs)

Related to #273

@skovhus skovhus merged commit 68f406b into main Jan 10, 2023
@skovhus skovhus deleted the logging branch January 10, 2023 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant