Stop wasting CPU cycles and memory for large workspaces #661
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Even though we limited the background analysis through the backgroundAnalysisMaxFiles config option, fast-glob continued in the background – potentially running out of memory... A lot of wasted CPU cycles.
skovhus
force-pushed
the
stop-wasting-resources
branch
from
0334ccc to
7a14ab3
Compare
This was referenced Jan 7, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Even though we limited the background analysis through the
backgroundAnalysisMaxFilesconfig option, the globbing library actually silently continued to find additional files matching the given glob – causing out of memory exceptions and wasting a lot of CPU cycles.This is now fixed and the CPU and memory usage is drastically reduced.
Related: #594 #630 #654 #638 #472 #297