Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "--shell=bash" argument for ShellCheck #536

Merged
merged 2 commits into from
Nov 16, 2022

Conversation

thomasjm
Copy link
Contributor

This PR adds the argument --shell=bash when invoking ShellCheck to improve robustness when you don't have a shebang or file extension that ShellCheck can use to determine the shell type. In particular, ShellCheck doesn't automatically assume .sh corresponds to Bash, which can lead to getting SC2148.

Since this language server is Bash-only, I figure it makes sense to always run ShellCheck in this mode.

@skovhus skovhus enabled auto-merge November 16, 2022 13:30
@skovhus skovhus merged commit d6a20ca into bash-lsp:main Nov 16, 2022
@adoyle-h
Copy link

@skovhus Could you please create a new release? I need this commit while using neovim, but the package installer only follows the latest release. Thanks.

@skovhus
Copy link
Collaborator

skovhus commented Nov 18, 2022

3.1.1 should be out now. Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants