Add "--shell=bash" argument for ShellCheck #536
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the argument
--shell=bash
when invoking ShellCheck to improve robustness when you don't have a shebang or file extension that ShellCheck can use to determine the shell type. In particular, ShellCheck doesn't automatically assume.sh
corresponds to Bash, which can lead to getting SC2148.Since this language server is Bash-only, I figure it makes sense to always run ShellCheck in this mode.