Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix completion kind info #466

Merged
merged 3 commits into from
Aug 1, 2022
Merged

Fix completion kind info #466

merged 3 commits into from
Aug 1, 2022

Conversation

deathaxe
Copy link

This PR assigns LSP.CompletionItemKind constants to completions.

Fixes #343

@skovhus skovhus enabled auto-merge August 1, 2022 20:07
Copy link
Collaborator

@skovhus skovhus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this!

@codecov
Copy link

codecov bot commented Aug 1, 2022

Codecov Report

Merging #466 (4e35fd3) into main (d3a0d1e) will not change coverage.
The diff coverage is n/a.

❗ Current head 4e35fd3 differs from pull request most recent head 89aa033. Consider uploading reports for the commit 89aa033 to get more accurate results

@@           Coverage Diff           @@
##             main     #466   +/-   ##
=======================================
  Coverage   74.55%   74.55%           
=======================================
  Files          19       19           
  Lines         668      668           
  Branches      118      118           
=======================================
  Hits          498      498           
  Misses        154      154           
  Partials       16       16           
Impacted Files Coverage Δ
server/src/server.ts 58.54% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us.

@skovhus skovhus merged commit f5645e7 into bash-lsp:main Aug 1, 2022
@deathaxe deathaxe deleted the fix-completion-kind-info branch August 2, 2022 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

KindInfo in auto-completion seems to be messed up
2 participants