Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix no diagnostics without WorkspaceFolders support #443

Conversation

a5ob7r
Copy link
Contributor

@a5ob7r a5ob7r commented Jun 28, 2022

Document diagnostics by shellcheck doesn't work without WorkspaceFolders support clients, because no response from the client about WorkspaceFolders and it blocks subsequent steps. To resolve this, send the request only if the client supports WorkspaceFolders.

Document diagnostics by shellcheck doesn't work without WorkspaceFolders
support clients, because no response from the client about
WorkspaceFolders and it blocks subsequent steps. To resolve this, send
the request only if the client supports WorkspaceFolders.
Copy link
Collaborator

@skovhus skovhus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this.

I’m curious: Which clients doesn’t support this?

@a5ob7r
Copy link
Contributor Author

a5ob7r commented Jun 29, 2022

I’m curious: Which clients doesn’t support this?

It's vim-lsp. Actually it supports WorkspaceFolders, but that feature is experimental and disabled by default now.
https://github.com/prabirshrestha/vim-lsp/blob/da80b018311b811eceac86fd0a59c521ffa9d2ab/doc/vim-lsp.txt#L2033

@skovhus skovhus enabled auto-merge July 3, 2022 21:11
@skovhus skovhus merged commit fb1b445 into bash-lsp:main Jul 3, 2022
@skovhus
Copy link
Collaborator

skovhus commented Jul 3, 2022

Released as 3.0.5. Does it work for you @a5ob7r?

@a5ob7r
Copy link
Contributor Author

a5ob7r commented Jul 4, 2022

@skovhus Yes, it works fine. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants