Fix file uri under Windows are incorrect #433
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #259
https://en.wikipedia.org/wiki/File_URI_scheme#Windows_2
You can't just prefix it with "file://".
Under Windows, that means it's a network location.
Let's just uses Node's API to do a proper conversion.
https://nodejs.org/api/url.html#urlpathtofileurlpath
Signed-off-by: Jack Cherng [email protected]