Fix analyzer not being called when getHighlightParsingError is off #396
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My apologies, looks like I let a regression slip through. I inadvertently allowed the call to the analyzer to be gated behind the
getHighlightParsingError
function, so if it was off, document trees were never being analysed and cached, breaking lots of things.It's a bit hard to write a test for at the moment, given
config
is global. @skovhus, are you comfortable with me replacing accesses to the global config functions with an interface type passed in as a dependency toBashServer
? This will make it trivial to inject different values in a test case. Is there a better way to do this?There was also an issue where TypeScript seems to not notice that
undefined
can come out ofuriToTreeSitterTrees
, and we were trying to accessrootNodes
against a document even if it wasn't found.