Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Multiline Comments #348

Merged

Conversation

lnxbil
Copy link
Contributor

@lnxbil lnxbil commented Apr 14, 2022

The overlay should be able to display comments that belong together,
even when an empty comment line is in between, e.g.

# foo
#
# bar

should be allowed and this patch enables this.

(may solve #347)

lnxbil and others added 4 commits April 14, 2022 15:31
The overlay should be able to display comments that belong together,
even when an empty comment line is in between, e.g.

    # foo
    #
    # bar

should be allowed and this patch enables this.

(may solve bash-lsp#347)
@skovhus skovhus enabled auto-merge April 17, 2022 20:04
@codecov
Copy link

codecov bot commented Apr 17, 2022

Codecov Report

Merging #348 (4cbf2b3) into master (b73c1fd) will not change coverage.
The diff coverage is 100.00%.

❗ Current head 4cbf2b3 differs from pull request most recent head 19e0cea. Consider uploading reports for the commit 19e0cea to get more accurate results

@@           Coverage Diff           @@
##           master     #348   +/-   ##
=======================================
  Coverage   72.91%   72.91%           
=======================================
  Files          18       18           
  Lines         576      576           
  Branches       94       94           
=======================================
  Hits          420      420           
  Misses        135      135           
  Partials       21       21           
Impacted Files Coverage Δ
server/src/analyser.ts 83.23% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 204ff98...19e0cea. Read the comment docs.

Copy link
Collaborator

@skovhus skovhus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution! I simplified the code a bit by checking if the return value was null.

@skovhus skovhus merged commit fd40332 into bash-lsp:master Apr 17, 2022
@lnxbil
Copy link
Contributor Author

lnxbil commented Apr 19, 2022

Thanks for the contribution! I simplified the code a bit by checking if the return value was null.

Yes, perfekt. Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants