Fix failing to get options if bash-completion<=2.9 #340
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bumps [urijs](https://github.com/medialize/URI.js) from 1.19.8 to 1.19.9. - [Release notes](https://github.com/medialize/URI.js/releases) - [Changelog](https://github.com/medialize/URI.js/blob/gh-pages/CHANGELOG.md) - [Commits](medialize/URI.js@v1.19.8...v1.19.9) --- updated-dependencies: - dependency-name: urijs dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]>
Bumps [urijs](https://github.com/medialize/URI.js) from 1.19.9 to 1.19.10. - [Release notes](https://github.com/medialize/URI.js/releases) - [Changelog](https://github.com/medialize/URI.js/blob/gh-pages/CHANGELOG.md) - [Commits](medialize/URI.js@v1.19.9...v1.19.10) --- updated-dependencies: - dependency-name: urijs dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]>
get-options.sh fails in older systems like Ubuntu 18.04. This is because the 'datadir' field in the .pc file was introduced in bash-completion v2.10. I suppose using the 'completionsdir' variable is a better option for compatibility because it exists for a while.
yamaton
force-pushed
the
fix-get-options
branch
from
2fc526d to
23c12e1
Compare
Codecov Report
@@ Coverage Diff @@
## master #340 +/- ##
=======================================
Coverage 72.91% 72.91%
=======================================
Files 18 18
Lines 576 576
Branches 94 94
=======================================
Hits 420 420
Misses 135 135
Partials 21 21 Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
get-options.sh fails in older systems like Ubuntu 18.04.
This is because the 'datadir' field in the .pc file was
introduced in bash-completion v2.10.
I suppose using the 'completionsdir' variable is a better
option for compatibility because it exists for a while.