Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix failing to get options if bash-completion<=2.9 #340

Merged
merged 6 commits into from
Apr 5, 2022

Conversation

yamaton
Copy link
Contributor

@yamaton yamaton commented Mar 9, 2022

get-options.sh fails in older systems like Ubuntu 18.04.
This is because the 'datadir' field in the .pc file was
introduced in bash-completion v2.10.

I suppose using the 'completionsdir' variable is a better
option for compatibility because it exists for a while.

dependabot bot and others added 3 commits March 11, 2022 14:08
Bumps [urijs](https://github.com/medialize/URI.js) from 1.19.8 to 1.19.9.
- [Release notes](https://github.com/medialize/URI.js/releases)
- [Changelog](https://github.com/medialize/URI.js/blob/gh-pages/CHANGELOG.md)
- [Commits](medialize/URI.js@v1.19.8...v1.19.9)

---
updated-dependencies:
- dependency-name: urijs
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>
Bumps [urijs](https://github.com/medialize/URI.js) from 1.19.9 to 1.19.10.
- [Release notes](https://github.com/medialize/URI.js/releases)
- [Changelog](https://github.com/medialize/URI.js/blob/gh-pages/CHANGELOG.md)
- [Commits](medialize/URI.js@v1.19.9...v1.19.10)

---
updated-dependencies:
- dependency-name: urijs
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>
get-options.sh fails in older systems like Ubuntu 18.04.
This is because the 'datadir' field in the .pc file was
introduced in bash-completion v2.10.

I suppose using the 'completionsdir' variable is a better
option for compatibility because it exists for a while.
@codecov
Copy link

codecov bot commented Mar 21, 2022

Codecov Report

Merging #340 (87676a4) into master (ef6ff4e) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #340   +/-   ##
=======================================
  Coverage   72.91%   72.91%           
=======================================
  Files          18       18           
  Lines         576      576           
  Branches       94       94           
=======================================
  Hits          420      420           
  Misses        135      135           
  Partials       21       21           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6ee9826...87676a4. Read the comment docs.

@skovhus skovhus merged commit decaa36 into bash-lsp:master Apr 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants