Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix invalid document highlights #209

Merged
merged 4 commits into from
Apr 14, 2020
Merged

Conversation

skovhus
Copy link
Collaborator

@skovhus skovhus commented Apr 14, 2020

Fixes #206

@codecov
Copy link

codecov bot commented Apr 14, 2020

Codecov Report

Merging #209 into master will increase coverage by 0.97%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #209      +/-   ##
==========================================
+ Coverage   68.93%   69.91%   +0.97%     
==========================================
  Files          18       18              
  Lines         470      472       +2     
  Branches       67       68       +1     
==========================================
+ Hits          324      330       +6     
+ Misses        129      125       -4     
  Partials       17       17              
Impacted Files Coverage Δ
server/src/server.ts 60.20% <100.00%> (+4.99%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b5a23a2...7b75dee. Read the comment docs.

@skovhus skovhus force-pushed the fix-invalid-document-highlights branch from 63dfbc6 to 7b75dee Compare April 14, 2020 09:31
@skovhus skovhus merged commit 64a356f into master Apr 14, 2020
@skovhus skovhus deleted the fix-invalid-document-highlights branch April 14, 2020 09:52
akurtakov added a commit to akurtakov/shellwax that referenced this pull request Apr 14, 2020
LS changes:
Fix invalid documentHighlight response when word cannot be found
(bash-lsp/bash-language-server#209)

Update links in readme to point to new home of bash lsp and shellwax
itself.

Signed-off-by: Alexander Kurtakov <[email protected]>
akurtakov added a commit to akurtakov/shellwax that referenced this pull request Apr 21, 2020
LS changes:
Fix invalid documentHighlight response when word cannot be found
(bash-lsp/bash-language-server#209)

Update links in readme to point to new home of bash lsp and shellwax
itself.

Signed-off-by: Alexander Kurtakov <[email protected]>
akurtakov added a commit to eclipse-shellwax/shellwax that referenced this pull request Apr 21, 2020
LS changes:
Fix invalid documentHighlight response when word cannot be found
(bash-lsp/bash-language-server#209)

Update links in readme to point to new home of bash lsp and shellwax
itself.

Signed-off-by: Alexander Kurtakov <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Invalid response for documentHightlight
1 participant