Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to tree-sitter-wasm (node 12 compatible) #147

Merged
merged 5 commits into from
Sep 23, 2019
Merged

Conversation

skovhus
Copy link
Collaborator

@skovhus skovhus commented Sep 21, 2019

We have several issues related to treesitter-node:

This PR we are switching to tree-sitter-wasm, which should be slower than the node version, but seems to be fast enough. And as there are no native dependencies, we can get rid of the npm install step (in the next PR). 😎

Context tree-sitter/node-tree-sitter#46 (comment)

TODO

  • integrate tree-sitter-wasm
  • test on OSX
  • test on Windows
  • performance test on node 10 the test have increased from 4 to 5 seconds
  • documentation

@skovhus skovhus force-pushed the switch-to-wasm branch 2 times, most recently from 421ccb3 to 8d005ad Compare September 22, 2019 17:31
@skovhus skovhus changed the title Switch to tree-sitter-wasm (compatible with node 12) Switch to tree-sitter-wasm and remove install step Sep 22, 2019
@skovhus skovhus force-pushed the switch-to-wasm branch 4 times, most recently from 8f4bd98 to 94f63ef Compare September 22, 2019 19:49
@skovhus skovhus changed the title Switch to tree-sitter-wasm and remove install step Switch to tree-sitter-wasm (node 12 compatible) Sep 22, 2019
@skovhus skovhus force-pushed the switch-to-wasm branch 2 times, most recently from 1e61f2f to ccacc8d Compare September 22, 2019 20:28
@skovhus skovhus mentioned this pull request Sep 22, 2019
Copy link
Collaborator

@mads-hartmann mads-hartmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@skovhus Amazing 👏

@skovhus skovhus marked this pull request as ready for review September 23, 2019 18:59
@skovhus skovhus merged commit cfb04ba into master Sep 23, 2019
@skovhus skovhus deleted the switch-to-wasm branch September 23, 2019 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants