Switch to tree-sitter-wasm (node 12 compatible) #147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skovhus
force-pushed
the
switch-to-wasm
branch
2 times, most recently
from
421ccb3 to
8d005ad
Compare
skovhus
changed the title
skovhus
force-pushed
the
switch-to-wasm
branch
4 times, most recently
from
8f4bd98 to
94f63ef
Compare
skovhus
changed the title
skovhus
force-pushed
the
switch-to-wasm
branch
2 times, most recently
from
1e61f2f to
ccacc8d
Compare
Compiled with "yarn tree-sitter build-wasm node_modules/tree-sitter-bash"
skovhus
force-pushed
the
switch-to-wasm
branch
from
ccacc8d to
947699b
Compare
Closed
mads-hartmann
approved these changes
Sep 23, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have several issues related to treesitter-node:
This PR we are switching to tree-sitter-wasm, which should be slower than the node version, but seems to be fast enough. And as there are no native dependencies, we can get rid of the npm install step (in the next PR). 😎
Context tree-sitter/node-tree-sitter#46 (comment)
TODO
performance teston node 10 the test have increased from 4 to 5 seconds