Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additional shfmt options #1168

Merged
merged 6 commits into from
Jun 2, 2024

Conversation

chris-reeves
Copy link
Contributor

There will likely be a subsequent PR to add support for .editorconfig once this is merged.

This may preempt further questions similar to bash-lsp#1161.
This wasn't included initially as it has been deprecated:
mvdan/sh#658

However, it has been mentioned in bash-lsp#1165 and is a valid option in the
current version of `shfmt`, so support has been added (with a suitable
deprecation warning).
This wasn't included initially as it does more than just format code.
However, its absence has been noted in a comment on the last PR:
bash-lsp#1136 (comment)
and it is a valid `shfmt` option, so support has been added.

There's a similar option (`-mn` or `--minify`), but this will not be
implemented as its output is not intended for human consumption and it
will essentially ignore all other options presented anyway.
This will aid in language dialect detection.
Copy link

codecov bot commented Jun 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.27%. Comparing base (522a5d6) to head (773a61c).
Report is 2 commits behind head on main.

Current head 773a61c differs from pull request most recent head 3a5ac07

Please upload reports for the commit 3a5ac07 to get more accurate results.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1168      +/-   ##
==========================================
+ Coverage   81.21%   81.27%   +0.05%     
==========================================
  Files          29       29              
  Lines        1411     1415       +4     
  Branches      335      338       +3     
==========================================
+ Hits         1146     1150       +4     
  Misses        218      218              
  Partials       47       47              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@skovhus skovhus enabled auto-merge June 2, 2024 20:07
@skovhus skovhus merged commit fe93389 into bash-lsp:main Jun 2, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants