Upgrade dependencies

[Jimmyscene]

Upgrade web-tree-sitter, tree-sitter-cli and tree-sitter-bash

These sort of all need to be done at the same time else everything blows up

Update rootNode.hasError() to hasError per
https://github.com/tree-sitter/tree-sitter/pull/3103/files

Update build-wasm flag to build --wasm per
tree-sitter/tree-sitter@99b93d8

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.52%. Comparing base (8f06a20) to head (f8b202b).
Report is 1 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1148      +/-   ##
==========================================
+ Coverage   81.50%   81.52%   +0.02%     
==========================================
  Files          28       28              
  Lines        1346     1348       +2     
  Branches      319      320       +1     
==========================================
+ Hits         1097     1099       +2     
  Misses        204      204              
  Partials       45       45              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[Jimmyscene]

when argumentNode.text == 'source "./issue206.sh"', argumentNode.namedChildren contains an element that is string_content with text=='"./issue206.sh"'

I am no expert here, so while this does fix it, there may be a better/more robust way to handle this

[Jimmyscene]

As I note in the commit message,

The anazlyer is now detecting variables within arithmetic expressions,
but still not let, postfix, or binary expressions

So a rename on

for i in 1 2 3; do
	echo "$i"
done

let i=0
for (( ; i < 10; i++)); do
	echo "$((2 * i))"
done

Would be changed to

for new_name in 1 2 3; do
	echo "$new_name"
done

let i=0
for (( ; i < 10; i++)); do
	echo "$((2 * new_name))"
done

Which is definitely wrong, but I'm interested to hear opinions from the maintainers on this. We already have a test checking that treesitter can't adequately rename these

[skovhus]

@mcecode what do you think about this?

[mcecode]

I think this is to be expected since, as far as I can tell, tree-sitter-bash only updated the types of variables from word to variable_name within arithmetic expressions. For those other constructs they're still typed as word. The current implementation of rename symbol only renames variables typed as variable_name.

[mcecode]

Since I was tagged, I'll leave some thoughts/notes here.

If/once this gets merged, #1134 can be closed as per my comment there #1134 (comment).

#943 can also be closed since that's just urging us to upgrade. On that note, I think tree-sitter-bash can be installed as is from the npm registry now instead of the latest from GitHub since they've started shipping stable versions there again, the latest being 0.21.

[skovhus]

Thanks @Jimmyscene – and thank you @mcecode for adding valuable comments.

[Jimmyscene]

Thanks @Jimmyscene – and thank you @mcecode for adding valuable comments.

Thanks for merging @skovhus - It looks like the Personal Access Token is expired per: https://github.com/bash-lsp/bash-language-server/actions/runs/8806526335/job/24171555526#step:6:116

Edit. Link failed, but it's the Deploy VSCode Extension job