Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only analyze files that end with .sh in their names #111

Merged
merged 2 commits into from
Mar 19, 2019

Conversation

rcjsuen
Copy link
Contributor

@rcjsuen rcjsuen commented Mar 14, 2019

Closes #102.

Skip out on trying to parse directories that have a .sh suffix in their names. Otherwise, the language server will crash when trying to read a directory as a file.

rcjsuen added 2 commits March 14, 2019 10:37
Skip out on trying to parse directories that have a .sh suffix in
their names. Otherwise, the language server will crash when trying to
read a directory as a file.

Signed-off-by: Remy Suen <[email protected]>
@skovhus
Copy link
Collaborator

skovhus commented Mar 14, 2019

Thanks! There is a formatting issue. To fix it you can run yarn lint

I thought we had a pre-commit for this.

@rcjsuen
Copy link
Contributor Author

rcjsuen commented Mar 14, 2019

@skovhus (I think) I have made the necessary changes. The build looks green now.

@rcjsuen
Copy link
Contributor Author

rcjsuen commented Mar 19, 2019

Is there anything else I need to address to move this forward?

@skovhus
Copy link
Collaborator

skovhus commented Mar 19, 2019

@rcjsuen thanks for reminding me. 👍

@skovhus skovhus merged commit da02441 into bash-lsp:master Mar 19, 2019
@rcjsuen rcjsuen deleted the skip-dir branch March 19, 2019 12:47
@Yzrsah
Copy link

Yzrsah commented Mar 19, 2019

@rcjsuen thank you

@rcjsuen
Copy link
Contributor Author

rcjsuen commented Mar 19, 2019

@Yzrsah Happy to help. Seemed like a straightforward enough of a thing to fix. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Crashes repeatedly when encountering directories with .sh
3 participants