Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Initialize Autolab secrets #56

Merged
merged 15 commits into from
Apr 15, 2023
Merged

Initialize Autolab secrets #56

merged 15 commits into from
Apr 15, 2023

Conversation

damianhxy
Copy link
Member

@damianhxy damianhxy commented Apr 14, 2023 •
edited
Loading

  • Pass SECRET_KEY_BASE, LOCKBOX_MASTER_KEY and DEVISE_SECRET_KEY to Autolab via .env
  • Update .env.template accordingly
  • Add an initialize_secrets.sh script that runs on make and make update, warns people to update outdated .env files

To test, follow https://docs.autolabproject.com/installation/docker-compose/

BETWEEN STEPS 2 and 3: Checkout this PR, e.g. gh pr checkout 56
BETWEEN STEPS 4 and 5: Checkout the corresponding Autolab PR, e.g. cd Autolab; gh pr checkout 1881

Acceptance testing

  • Rest of the install steps work correctly
  • Autograding jobs work

Ref: autolab/Autolab#1881

@damianhxy damianhxy marked this pull request as ready for review April 14, 2023 22:31
@damianhxy damianhxy changed the title Create Autolab .env file and add mapping Initialize Autolab secrets Apr 14, 2023
@damianhxy damianhxy marked this pull request as draft April 14, 2023 22:35
@damianhxy damianhxy mentioned this pull request Apr 14, 2023
Merged
6 tasks
@damianhxy damianhxy marked this pull request as ready for review April 14, 2023 23:04
@damianhxy damianhxy requested a review from evanyeyeye April 14, 2023 23:04
evanyeyeye
evanyeyeye approved these changes Apr 14, 2023
View reviewed changes
Copy link
Member

@evanyeyeye evanyeyeye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@damianhxy damianhxy merged commit 296ce4a into master Apr 15, 2023
@damianhxy damianhxy deleted the initialize-secrets branch April 15, 2023 00:30
@damianhxy damianhxy mentioned this pull request Nov 12, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@evanyeyeye evanyeyeye evanyeyeye approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@damianhxy @evanyeyeye