-
Notifications
You must be signed in to change notification settings - Fork 228
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Button to clear cache (in dropdown) #1801
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Could you also update the documentation? Specifically: https://docs.autolabproject.com/installation/troubleshoot/#no-space-left-on-device |
damianhxy
requested changes
Feb 19, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Change method to
post
since it is not an idempotent operation and is vulnerable to CSRF attacks - Improve UX by redirecting to previous page where possible
damianhxy
approved these changes
Feb 19, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added a button to clear expired cache (cache cleanup).
On desktop
On mobile
After button is pressed
Motivation and Context
Previously, an admin had to run the command
rake user:cleanup_cache
to clear expired cache #1634 . This button makes it easier to do so.How Has This Been Tested?
Preliminary steps
rails dev:cache
config.cache_store = :memory_store
withconfig.cache_store = :file_store, "tmp/cache/scores"
Test that rake task clears expired entries
:expires_in
andrace_condition_ttl
to5.seconds
(in all 3 places)/tmp/cache/scores
is populatedManage Autolab
followed byClear Cache
, observe that the (expired) entries are clearedTest that rake task does not clear unexpired entries
:expires_in
andrace_condition_ttl
back to their original values/tmp/cache/scores
is populatedManage Autolab
followed byClear Cache
, observe that the unexpired entries are not clearedrake user:clear_cache
and observe that the entries are clearedTypes of changes
Checklist:
overcommit --install && overcommit --sign
to use pre-commit hook for linting