Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set default dates of new assessment to one day later than the present #1474

Merged
merged 1 commit into from
Mar 1, 2022

Conversation

xinyis991105
Copy link
Contributor

Description

See title.

Motivation and Context

So that students wouldn't see newly created assessments that they are not expected to work on yet.

How Has This Been Tested?

  1. Create a new assessment using an assessment builder. Without further editing, check course dashboard and confirm that it has the not released tag next to it. Act as a student. Confirm that student cannot see the assessment.
  2. Import an existing assessment. Without further editing, check course dashboard and confirm that it has the not released tag next to it. Act as a student. Confirm that student cannot see the assessment.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have run rubocop for style check. If you haven't, run overcommit --install && overcommit --sign to use pre-commit hook for linting
  • My change requires a change to the documentation, which is located at Autolab Docs
  • I have updated the documentation accordingly, included in this PR

Other issues / help required

If unsure, feel free to submit first and we'll help you along.

Verified

This commit was signed with the committer’s verified signature.
cg2v Chaskiel Grundman
Copy link
Contributor

@oliverli oliverli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xinyis991105 xinyis991105 merged commit 0d0df9f into master Mar 1, 2022
@xinyis991105 xinyis991105 deleted the default_date_fix branch March 1, 2022 22:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants