Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rails Upgrade to 6 #1470

Merged
merged 19 commits into from
Mar 22, 2022
Merged

Rails Upgrade to 6 #1470

merged 19 commits into from
Mar 22, 2022

Conversation

xinyis991105
Copy link
Contributor

Description

This PR upgrades rails to 6 along with the necessary gems.

Motivation and Context

Keep up with the current latest rails.

How Has This Been Tested?

  1. Delete Gemfile.lock. Run bundle install.
  2. Drop the current database and re-migrate.
  3. Go through the behavioral testing plan.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have run rubocop for style check. If you haven't, run overcommit --install && overcommit --sign to use pre-commit hook for linting
  • My change requires a change to the documentation, which is located at Autolab Docs
  • I have updated the documentation accordingly, included in this PR

Other issues / help required

If unsure, feel free to submit first and we'll help you along.

@xinyis991105
Copy link
Contributor Author

linting is done and a reminder has been added in another commit

@oliverli oliverli requested a review from fanpu March 1, 2022 22:14
Copy link
Contributor

@fanpu fanpu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks Xinyi!

@xinyis991105 xinyis991105 merged commit be6b40c into master Mar 22, 2022
@xinyis991105 xinyis991105 deleted the rails-upgrade branch March 22, 2022 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants