Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change Max Submissions to Unpenalized Submissions in Autolab API #1333

Merged
merged 1 commit into from
Apr 20, 2021

Conversation

oliverli
Copy link
Contributor

@oliverli oliverli commented Apr 18, 2021

Description

Add max_unpenalized_submissions field to API's /courses/{course_name}/assessments/{assessment_name} endpoint

Motivation and Context

We want to show clients (especially in the CLI) the number of submissions they can make before they start incurring version penalties. Closes #1184

How Has This Been Tested?

Tested locally using Postman, with no version penalties, and with version penalties after 3 submissions

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My change requires a change to the documentation, which is located at Autolab Docs
  • I have updated the documentation accordingly, included in this PR

Other issues / help required

If unsure, feel free to submit first and we'll help you along.

Verified

This commit was signed with the committer’s verified signature.
cg2v Chaskiel Grundman
Copy link
Contributor

@victorhuangwq victorhuangwq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested the API. Correct result is returned after setting is updated as well.
LGTM!

@oliverli oliverli merged commit a9fed94 into master Apr 20, 2021
@oliverli oliverli deleted the oliverli/max-unpen-submission-api branch April 20, 2021 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[API] Change Max Submissions to Unpenalized Submissions in Autolab API
2 participants