Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes bug where replacing tags with no tags in input file was not removing any tags #1407

Merged
merged 1 commit into from
Mar 6, 2025

Conversation

cmgrote
Copy link
Collaborator

@cmgrote cmgrote commented Mar 6, 2025

No description provided.

@cmgrote cmgrote added bug Something isn't working packages Changes related to custom packages labels Mar 6, 2025
@cmgrote cmgrote requested a review from Copilot March 6, 2025 13:37

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Overview

This PR fixes a bug related to tag replacement by ensuring that tag handling is properly applied when no tags are provided in the input file. The changes update the flush logic in AssetBatch.java to pass the new tag handling parameter and refactor the AssetEndpoint.java API methods to consistently use AtlanTagHandling across various save methods.

  • Updates client asset save methods to include an additional tag handling parameter.
  • Introduces overloads in AssetEndpoint.java for better tag handling control.
  • Refactors helper methods to compute tag handling semantics and query parameters.

Reviewed Changes

File Description
sdk/src/main/java/com/atlan/util/AssetBatch.java Adds the tag handling parameter to client.assets.save calls in flush method.
sdk/src/main/java/com/atlan/api/AssetEndpoint.java Refactors and overloads save methods to support AtlanTagHandling and updates helper methods.

Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.

Comments suppressed due to low confidence (1)

sdk/src/main/java/com/atlan/api/AssetEndpoint.java:264

  • The variable name 'tagHanding' appears to be a typo; it should be renamed to 'tagHandling' for consistency.
AtlanTagHandling tagHanding = getTagHandling(values);
@cmgrote cmgrote enabled auto-merge March 6, 2025 13:38
@cmgrote cmgrote merged commit 7acc131 into main Mar 6, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working packages Changes related to custom packages
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant