This repository was archived by the owner on May 11, 2021. It is now read-only.
Fix PostgreSQL boolean handling for PHP 8.0.5 #299
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvorisek
force-pushed
the
fix_pgsql_test
branch
2 times, most recently
from
22fd43e to
66e9170
Compare
mvorisek
force-pushed
the
fix_pgsql_test
branch
from
4cc9c92 to
07a50b2
Compare
mvorisek
changed the title
mvorisek
commented
Apr 30, 2021
| $type = \PDO::PARAM_STR; | ||
| $val = $val ? '1' : '0'; | ||
| } else { | ||
| $type = \PDO::PARAM_INT; |
There was a problem hiding this comment.
At least Oracle does not support PARAM_BOOL with col = false in where condition.
|
@georgehristov please approve |
georgehristov
approved these changes
May 1, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related with php/php-src#6801 and PHP 8.0.5 release