This repository was archived by the owner on May 11, 2021. It is now read-only.
Fix tests for MSSQL #246
Merged
Fix tests for MSSQL #246
+174
−18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvorisek
commented
Sep 9, 2020
| @@ -542,10 +538,13 @@ public function execute(object $connection = null) | |||
| $statement->execute(); | |||
| } catch (\PDOException $e) { | |||
| $new = (new ExecuteException('DSQL got Exception when executing this query', $e->errorInfo[1])) | |||
| ->addMoreInfo('error', $e->errorInfo[2]) | |||
| ->addMoreInfo('error', $e->errorInfo[2] ?? 'n/a (' . $e->errorInfo[0] . ')') | |||
There was a problem hiding this comment.
errorInfo[2] is not set with MSSQL PDO driver
mvorisek
force-pushed
the
cross_vendor_fixes
branch
from
5917741 to
7a75b1b
Compare
mvorisek
changed the title
mvorisek
commented
Sep 9, 2020
| } else { | ||
| $bind = $statement->bindParam($key, $statement->boundValues[$key], $type); | ||
| } | ||
| $bind = $statement->bindParam($key, $statement->boundValues[$key], $type); |
There was a problem hiding this comment.
lenght should be set only if param is read back (in-out), not our case
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.