Skip to content
This repository was archived by the owner on May 11, 2021. It is now read-only.

Deduplicate value cast and add support for bool #203

Merged
merged 2 commits into from
May 7, 2020

Conversation

mvorisek
Copy link
Member

@mvorisek mvorisek commented May 2, 2020

For robustness and future, no bool type usage so far.

@mvorisek mvorisek marked this pull request as draft May 2, 2020 14:44
@codecov
Copy link

codecov bot commented May 2, 2020

Codecov Report

Merging #203 into develop will decrease coverage by 0.09%.
The diff coverage is 75.00%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop     #203      +/-   ##
=============================================
- Coverage      82.27%   82.17%   -0.10%     
- Complexity       396      399       +3     
=============================================
  Files             15       15              
  Lines            959      965       +6     
=============================================
+ Hits             789      793       +4     
- Misses           170      172       +2     
Impacted Files Coverage Δ Complexity Δ
src/Expression.php 87.40% <75.00%> (-0.51%) 94.00 <5.00> (+3.00) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update acf31e6...20673aa. Read the comment docs.

@mvorisek mvorisek marked this pull request as ready for review May 2, 2020 14:46
@mvorisek mvorisek requested a review from DarkSide666 May 2, 2020 14:46
Copy link
Member

@DarkSide666 DarkSide666 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no more code duplication - good.

@DarkSide666 DarkSide666 merged commit 8f119a2 into develop May 7, 2020
@DarkSide666 DarkSide666 deleted the separate_get_cast branch May 7, 2020 19:18
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants