-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace Model::persistence property with getter/setter #948
Merged
mvorisek
merged 7 commits into
develop
from
persistence_add_called_only_from_constructor
Jun 29, 2022
Merged
Replace Model::persistence property with getter/setter #948
mvorisek
merged 7 commits into
develop
from
persistence_add_called_only_from_constructor
Jun 29, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a2ca9fb
to
d263710
Compare
d263710
to
3bdbd6c
Compare
3bdbd6c
to
4c65e89
Compare
4c65e89
to
1d415f8
Compare
af17abf
to
6bf16d4
Compare
6bf16d4
to
34202ef
Compare
fd828eb
to
5727b8d
Compare
5727b8d
to
77d50e8
Compare
This was referenced Jun 29, 2022
DarkSide666
reviewed
Jun 30, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Have to fix tests.
what tests you mean? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
previously
Persistence::add()
was not called whenModel::persistence
was set and it implied noPersistence::HOOK_AFTER_ADD
hook was calledthis PR fixes it by replacing
Model::persistence
property with persistence getter/setterwith the newly introduced persitence
Model::setPersistence()
setter,Persistence:add()
call does not make any logical sense ( persistence can be set only once and never unset) and thus directPersistence:add()
call newly throws an exceptionHere are several examples how to upgrade your code when setting persistence:
regex to locate old usage:
(?<!\w)(db|persistence)(?!\w).*->add\(
When accessing the persistence,
Model::getPersistence()
getter must be used and it throws when persistence is not set. To check if persistence is set, useModel::issetPersistence()
method.regex to locate old usage:
->persistence(?!\w)