Model only properties should be settable only from non-entity #940
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvorisek
commented
Dec 3, 2021
| @@ -380,14 +380,10 @@ public function compare($value, $value2): bool | |||
| return $this->getValueForCompare($value) === $this->getValueForCompare($value2); | |||
| } | |||
|
|
|||
| public function getReference(Model $entity = null): ?Reference | |||
| public function getReference(): ?Reference | |||
There was a problem hiding this comment.
Reference is model only, accepting entity was non-sense
mvorisek
force-pushed
the
no_set_of_model_fields_on_entity
branch
from
8855c9f to
db6b8c2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.