Accept DBAL driver connection in Connection::connect #939
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ect" This reverts commit 4f89420.
mvorisek
force-pushed
the
drop_create_conn_from_pdo
branch
3 times, most recently
from
57a6d40 to
d111b82
Compare
mvorisek
force-pushed
the
drop_create_conn_from_pdo
branch
from
d111b82 to
085d2a0
Compare
mvorisek
force-pushed
the
drop_create_conn_from_pdo
branch
from
10d5ad5 to
4cf733c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
and drop the acceptace of instanced PDO, it is not supported natively by DBAL 3.x