Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deduplicate Reference from entity #915

Merged
merged 10 commits into from
Nov 11, 2021
Merged

Deduplicate Reference from entity #915

merged 10 commits into from
Nov 11, 2021

Conversation

mvorisek
Copy link
Member

@mvorisek mvorisek commented Nov 11, 2021 •
edited
Loading

BC break

Reference is no longer bound to an entity, thus methods Reference::ref, Field::refModel, Field::refLink requires entity provided as the 1st argument like $ref->ref($entity). No change required if traversing from model/entity directly.

@mvorisek mvorisek force-pushed the nonentity_ref branch 9 times, most recently from 7024b28 to cb41ccf Compare November 11, 2021 15:55
@mvorisek mvorisek marked this pull request as ready for review November 11, 2021 21:31
DarkSide666
DarkSide666 approved these changes Nov 11, 2021
View reviewed changes
Copy link
Member

@DarkSide666 DarkSide666 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mvorisek mvorisek merged commit 54c8d07 into develop Nov 11, 2021
@mvorisek mvorisek deleted the nonentity_ref branch November 11, 2021 23:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DarkSide666 DarkSide666 DarkSide666 approved these changes

@georgehristov georgehristov Awaiting requested review from georgehristov

Assignees
No one assigned
Labels
BC-break RTM
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mvorisek @DarkSide666