Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require field to be present when typecasting a row #898

Merged
merged 5 commits into from
Oct 14, 2021

Conversation

mvorisek
Copy link
Member

@mvorisek mvorisek commented Oct 2, 2021

Important for a security, we can not leave anything uncasted if not found.

@mvorisek mvorisek force-pushed the typecast_field_must_exists branch 3 times, most recently from af32c4d to 4300f5b Compare October 4, 2021 11:26
@mvorisek
Copy link
Member Author

mvorisek commented Oct 4, 2021

@georgehristov you know the data more internally, please help with this PR.

@mvorisek mvorisek force-pushed the typecast_field_must_exists branch from 4300f5b to 740efbe Compare October 11, 2021 20:43
Copy link
Member

@DarkSide666 DarkSide666 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pre-approving

@mvorisek mvorisek force-pushed the typecast_field_must_exists branch from cb06950 to 98f531c Compare October 14, 2021 18:59
@mvorisek mvorisek force-pushed the typecast_field_must_exists branch from 98f531c to fe2b81c Compare October 14, 2021 19:03
@mvorisek mvorisek force-pushed the typecast_field_must_exists branch from fe2b81c to 8cbc021 Compare October 14, 2021 19:05
@mvorisek mvorisek marked this pull request as ready for review October 14, 2021 19:05
@mvorisek mvorisek added the RTM label Oct 14, 2021
@mvorisek mvorisek force-pushed the typecast_field_must_exists branch from 6838319 to 2499014 Compare October 14, 2021 19:15
@mvorisek mvorisek merged commit c7883d8 into develop Oct 14, 2021
@mvorisek mvorisek deleted the typecast_field_must_exists branch October 14, 2021 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants