Upgrade phpstan to level 6 #871

mvorisek · 2021-05-05T18:57:51Z

BC break

Atk4\Schema\PhpunitTestCase::getMigrator() method renamed to Atk4\Schema\PhpunitTestCase::createMigrator()

georgehristov

DBAL connection getSchemaManager is also renamed to createSchemaManager

mvorisek added the help wanted label May 5, 2021

mvorisek added 2 commits May 10, 2021 11:17

return void in phpunit test methods

86e78ec

remove dummy "test constructor" desc

24cb38a

mvorisek force-pushed the phpstan_l6 branch from c8b82b4 to 788869d Compare May 10, 2021 09:17

change join string from "," to ", "

d08c65c

mvorisek force-pushed the phpstan_l6 branch from 788869d to e68e19f Compare May 10, 2021 09:25

mvorisek requested review from DarkSide666 and georgehristov May 10, 2021 09:26

mvorisek removed the help wanted label May 10, 2021

mvorisek marked this pull request as ready for review May 10, 2021 09:26

Expression implements Expressionable

4fb2ec8

mvorisek force-pushed the phpstan_l6 branch 2 times, most recently from 9eac1bd to cf32adf Compare May 10, 2021 11:43

Upgrade phpstan to level 6

0428c2f

mvorisek force-pushed the phpstan_l6 branch from 1f2f571 to 0428c2f Compare May 10, 2021 13:28

mvorisek added BC-break RTM waitingForAnotherPR labels May 10, 2021

mvorisek mentioned this pull request May 10, 2021

Upgrade phpstan to level 6 atk4/ui#1630

Merged

mvorisek force-pushed the phpstan_l6 branch from 2786407 to 41df7c0 Compare May 11, 2021 07:56

georgehristov approved these changes May 11, 2021

View reviewed changes

fix cs

3daa866

mvorisek force-pushed the phpstan_l6 branch from 41df7c0 to 3daa866 Compare May 11, 2021 08:50

fix mysql expected str

36fadf5

mvorisek removed the waitingForAnotherPR label May 11, 2021

mvorisek merged commit 8c04363 into develop May 11, 2021

mvorisek deleted the phpstan_l6 branch May 11, 2021 09:03