Fix "field" action - return all records, allow Action as scope condition #861
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvorisek
force-pushed
the
fix_field_action
branch
2 times, most recently
from
008adbd to
7d598f1
Compare
This was referenced Apr 22, 2021
|
@georgehristov can you please review? Do you know why 7d598f1#diff-facfb8206c512f6ada3a34d73c4ed464957c84987a77f986e2b8357bca34ab29R205 is needed to NOT check keys? The scope is for |
mvorisek
force-pushed
the
fix_field_action
branch
3 times, most recently
from
f99fa4c to
89912a6
Compare
mvorisek
commented
Apr 23, 2021
src/Persistence/Array_.php
Outdated
|
|
||
| if ($id === self::ID_LOAD_ONE || $id === self::ID_LOAD_ANY) { | ||
| if (count($this->data[$model->table]) === 0) { | ||
| $action = $this->action($model, 'select'); | ||
| $action->generator->rewind(); // needed for some reasons! |
There was a problem hiding this comment.
why is this needed, should this be done in the action itself?
mvorisek
changed the title
DarkSide666
approved these changes
Apr 23, 2021
There was a problem hiding this comment.
LGTM, but would be good if @georgehristov could take a look too
mvorisek
force-pushed
the
fix_field_action
branch
from
89912a6 to
08dd4ba
Compare
mvorisek
force-pushed
the
fix_field_action
branch
from
b765e0c to
2085c78
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
merge after #860
also fixes array persistence
tryLoadwhich previously was completely ignoring all conditions (they were used only when loading data using iterator)