Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update hintable dep to 1.2.x #851

Merged
merged 1 commit into from
Apr 15, 2021
Merged

Update hintable dep to 1.2.x #851

merged 1 commit into from
Apr 15, 2021

Conversation

mvorisek
Copy link
Member

@mvorisek mvorisek commented Apr 15, 2021 •
edited
Loading

now we also allow only 1.2.* instead of 1.*

@mvorisek mvorisek added the RTM label Apr 15, 2021
@mvorisek mvorisek mentioned this pull request Apr 15, 2021
Merged
georgehristov
georgehristov approved these changes Apr 15, 2021
View reviewed changes
Copy link
Collaborator

@georgehristov georgehristov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mvorisek
Copy link
Member Author

mvorisek commented Apr 15, 2021 •
edited
Loading

@georgehristov any idea how to fix https://github.com/mvorisek/atk4-hintable-mirror/blob/develop/tests/Data/HintableModelTest.php#L102 ? (related with references and scopes)

currently it requires persistence set before ref() can be even returned

@mvorisek mvorisek merged commit b08661f into develop Apr 15, 2021
@mvorisek mvorisek deleted the update_hintable_dep branch April 15, 2021 13:23
@georgehristov
Copy link
Collaborator

@ghristov#5652 any idea how to fix https://github.com/mvorisek/atk4-hintable-mirror/blob/develop/tests/Data/HintableModelTest.php#L102 ? (related with references and scopes)

currently it requires persistence set before ref() can be even returned

@mvorisek you referenced somebody else :)

Anyway I will have a look

@mvorisek
Copy link
Member Author

mvorisek commented Apr 16, 2021 •
edited
Loading

@georgehristov did you find a solution?

update: link with fixed version/commit is: https://github.com/mvorisek/atk4-hintable-mirror/blob/1.2.1/tests/Data/HintableModelTest.php#L100

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@georgehristov georgehristov georgehristov approved these changes

@DarkSide666 DarkSide666 Awaiting requested review from DarkSide666

Assignees
No one assigned
Labels
RTM
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mvorisek @georgehristov