Make Persistence class abstract #847
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvorisek
force-pushed
the
abstract_persistence
branch
2 times, most recently
from
993a7a8 to
4b3d4e8
Compare
mvorisek
force-pushed
the
abstract_persistence
branch
2 times, most recently
from
cae8520 to
fd22962
Compare
mvorisek
force-pushed
the
abstract_persistence
branch
from
20e6c91 to
a148ab1
Compare
DarkSide666
approved these changes
Apr 7, 2021
| @@ -239,7 +239,7 @@ public function typecastLoadRow(Model $model, array $row): array | |||
| public function tryLoad(Model $model, $id): ?array | |||
| { | |||
| if ($id !== self::ID_LOAD_ANY) { | |||
| throw new \Error/*Exception*/ ('CSV Persistence does not support other than LOAD ANY mode'); // @TODO we can iterate... | |||
| throw new Exception('CSV Persistence does not support other than LOAD ANY mode'); // @TODO | |||
There was a problem hiding this comment.
lost comment "we can iterate"
There was a problem hiding this comment.
we can iterate was introduced by me yesterday, today I removed it, by ìterate I meant another PR which I found a little confusing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
finish after #846