Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve PHPStan level to 5 #814

Merged
merged 6 commits into from
Dec 26, 2020
Merged

Improve PHPStan level to 5 #814

merged 6 commits into from
Dec 26, 2020

Conversation

mvorisek
Copy link
Member

@mvorisek mvorisek commented Dec 21, 2020

BC break - Model without table:

update code like: $m = new Model($db, false);
to: $m = new Model($db, ['table' => false]);

BC break - hasOne (Reference::$model can not be a string seed):

update code like: $this->hasOne('parent_folder_id', Folder::class];
to $this->hasOne('parent_folder_id', ['model' => [Folder::class]]);

@mvorisek mvorisek force-pushed the improve_phpstan branch 2 times, most recently from 32925e9 to 1496b55 Compare December 25, 2020 20:25
@mvorisek mvorisek changed the title Improve PHPStan level to 3 Improve PHPStan level to 4 Dec 25, 2020
@mvorisek mvorisek force-pushed the improve_phpstan branch 4 times, most recently from 5d35ab6 to 0d9cffc Compare December 25, 2020 22:13
@mvorisek mvorisek changed the title Improve PHPStan level to 4 Improve PHPStan level to 5 Dec 25, 2020
@mvorisek mvorisek marked this pull request as ready for review December 25, 2020 23:19
@mvorisek mvorisek merged commit 6ce8726 into develop Dec 26, 2020
@mvorisek mvorisek deleted the improve_phpstan branch December 26, 2020 22:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants