Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Join last inserted ID source #777

Merged
merged 5 commits into from
Oct 14, 2021
Merged

Fix Join last inserted ID source #777

merged 5 commits into from
Oct 14, 2021

Conversation

mvorisek
Copy link
Member

@mvorisek mvorisek commented Nov 3, 2020 •
edited
Loading

No description provided.

@mvorisek mvorisek force-pushed the null_pk_insert branch 2 times, most recently from a166506 to 1998097 Compare November 3, 2020 15:43
@mvorisek mvorisek changed the title Fix NULL PK not unset in INSERT Do not set PK to NULL on INSERT Oct 1, 2021
@mvorisek mvorisek added the bug label Oct 1, 2021
@mvorisek mvorisek marked this pull request as ready for review October 14, 2021 16:57
@mvorisek mvorisek requested a review from DarkSide666 October 14, 2021 16:57
@mvorisek mvorisek changed the title Do not set PK to NULL on INSERT Fix Join last inserted ID source Oct 14, 2021
@mvorisek mvorisek added the RTM label Oct 14, 2021
DarkSide666
DarkSide666 approved these changes Oct 14, 2021
View reviewed changes
Copy link
Member

@DarkSide666 DarkSide666 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure why it's needed, but ok :)

@mvorisek mvorisek merged commit 717d3fd into develop Oct 14, 2021
@mvorisek mvorisek deleted the null_pk_insert branch October 14, 2021 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DarkSide666 DarkSide666 DarkSide666 approved these changes

Assignees
No one assigned
Labels
bug RTM
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mvorisek @DarkSide666