Fix Array persistence with Datetime fields #739
Conversation
| $m->save(); | ||
|
|
||
| //try setting DateTime Object | ||
| $dateTime = \DateTime::createFromFormat('Y-m-d H:i:s', '2020-01-01 11:11:11'); |
There was a problem hiding this comment.
new \DateTime('2020-01-01 11:11:11') is enough
| $m->set('datetime', $dateTime); | ||
| $m->save(); | ||
|
|
||
| self::assertInstanceOf( |
There was a problem hiding this comment.
keep on 1 line, also, probably use $this->assert to be consistent
There was a problem hiding this comment.
Does StyleCI command this? I find assertions way more readable this way.
There was a problem hiding this comment.
1 line - keep files short - important in general
|
valid usecase - related with #727 we should typecase inside Field to an unmanaged object/string and twice (to/from) for normalize probably also related with #690 UPDATE: #690 does not solve it, array persistence simply does not care about typecasting, which is wrong, as object can not be compared at all (in sense of non strict equality) and typecasting/normalize thru field Type seems to be the only correct approach |
mvorisek
changed the title
|
Yes, this sounds reasonable. In general I am not happy adding another typecasting to this persistence. You and Georgi already put a lot of thought in this topic, and as far as I understood you have some good idea how to fix typecasting issues on a different level. |
|
Is this still valid with #804 ? |
Currently, the added test fails and produces this error message:
The objective of this PR is to fix this issue. As no fix is provided yet, just a draft.