-
Notifications
You must be signed in to change notification settings - Fork 454
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Cofree comonad #94
Conversation
Codecov Report
@@ Coverage Diff @@
## master #94 +/- ##
=========================================
Coverage ? 50.44%
Complexity ? 143
=========================================
Files ? 65
Lines ? 902
Branches ? 129
=========================================
Hits ? 455
Misses ? 392
Partials ? 55
Continue to review full report at Codecov.
|
I'm only missing an example of running the monad with binding, if anyone could please provide it. |
StackOverflow fixes required, probably related to Eval.Compute#value() (https://github.com/FineCinnamon/Katz/blob/master/katz/src/main/kotlin/katz/data/Eval.kt#L176) Stack loop:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Aweosme work @pakoito . Can we add a stack safety test for Eval, I think that is critical to ensure other types built atop eval remain stacksafe
@raulraja I'm eager to merge this before CI breaks again! I'll add the tests in another PR today. |
* format on java time instances * add array codecs * add array codec test * fix map decoder * Update helios-core/src/main/kotlin/helios/instances/instancesCollections.kt Co-Authored-By: Simon Vergauwen <[email protected]> * address comments * some fixes after merge * little improvements
* Remove Id typeclass references * Remove Id tests
Closes #92