Add Yoneda and CoYoneda, along with their Functor instances #83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pakoito
commented
Apr 27, 2017
| typealias YonedaF<U> = HK<Yoneda.F, U> | ||
|
|
||
| // FIXME using YonedaKind throws a compiler error, but not the expanded form | ||
| interface Yoneda<FU, A> : HK<HK<Yoneda.F, FU>, A> { |
There was a problem hiding this comment.
A compiler bug, someone call the JB cops :D
There was a problem hiding this comment.
The bug went away when I tried to compile again to get a debug trace. I've reported it anyway to https://youtrack.jetbrains.com/issue/KT-17619
There was a problem hiding this comment.
The bug came back so I reverted it.
jrgonzalezg
approved these changes
May 7, 2017
Codecov Report
@@ Coverage Diff @@
## master #83 +/- ##
===========================================
+ Coverage 47.05% 47.7% +0.65%
- Complexity 120 127 +7
===========================================
Files 58 62 +4
Lines 831 851 +20
Branches 131 131
===========================================
+ Hits 391 406 +15
- Misses 390 395 +5
Partials 50 50
Continue to review full report at Codecov.
|
ambrusadrianz
pushed a commit
to ambrusadrianz/arrow
that referenced
this pull request
Oct 22, 2019
rachelcarmena
pushed a commit
that referenced
this pull request
Feb 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add two central pieces to the Free machinery: Yoneda and CoYoneda. They include a minimal implementation, along with a Functor instance. I've also written a minimal test suite for each.
For consistency purposes I've swapped the parameter order in the Free class.
Closes #80