Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix position of default argument for monad implicit to align with Kotlin expectation #81

Merged
merged 4 commits into from
Apr 23, 2017

Conversation

pakoito
Copy link
Member

@pakoito pakoito commented Apr 23, 2017

Skipping default parameters only works for the last parameter position. Kleisli didn't follow this convention.

screen shot 2017-04-23 at 11 00 13 pm

@pakoito pakoito self-assigned this Apr 23, 2017
@pakoito pakoito merged commit 51bb27c into master Apr 23, 2017
@pakoito pakoito deleted the paco-fixdefaultsinkleisi branch April 23, 2017 22:14
@codecov
Copy link

codecov bot commented Apr 23, 2017

Codecov Report

❗ No coverage uploaded for pull request base (master@8b6242d). Click here to learn what that means.
The diff coverage is 20%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master      #81   +/-   ##
=========================================
  Coverage          ?   41.94%           
  Complexity        ?       81           
=========================================
  Files             ?       40           
  Lines             ?      720           
  Branches          ?      124           
=========================================
  Hits              ?      302           
  Misses            ?      373           
  Partials          ?       45
Impacted Files Coverage Δ Complexity Δ
katz/src/main/kotlin/katz/data/Reader.kt 37.5% <0%> (ø) 3 <2> (?)
katz/src/main/kotlin/katz/data/Kleisli.kt 78.57% <50%> (ø) 5 <0> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8b6242d...ff28623. Read the comment docs.

ambrusadrianz pushed a commit to ambrusadrianz/arrow that referenced this pull request Oct 22, 2019
* Fix Gradle task names

* Apply the same fix in benchmarks docs
rachelcarmena pushed a commit that referenced this pull request Feb 24, 2021
* Deprecate Each typeclass

* Remove unused annotation

* Replace each with traversal in tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants