-
Notifications
You must be signed in to change notification settings - Fork 454
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement OptionT as HK2 #52
Conversation
use tipealias for HKX
Codecov Report
@@ Coverage Diff @@
## rr-option-transformer #52 +/- ##
=====================================================
Coverage ? 0%
=====================================================
Files ? 1
Lines ? 2
Branches ? 0
=====================================================
Hits ? 0
Misses ? 2
Partials ? 0 Continue to review full report at Codecov.
|
fa.ev().map(f) | ||
|
||
override fun <A> pure(a: A): HK<Id.F, A> = Id(a) | ||
override fun <A> pure(a: A): Id<A> = Id(a) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could use HK<Id.F,A>
or Id<A>
which is better here and other monads?
I prefer hide as much as posible the HK hack but and only have it only as parameters and not in return types
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Always take as args as generic as you can and return as concrete as you can is a good rule of thumb
fa.ev().map(f) | ||
|
||
override fun <A> pure(a: A): HK<Id.F, A> = Id(a) | ||
override fun <A> pure(a: A): Id<A> = Id(a) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Always take as args as generic as you can and return as concrete as you can is a good rule of thumb
* Implement OptionT as HK2 use tipealias for HKX * add missing methods
* Implement OptionT as HK2 use tipealias for HKX * add missing methods
* Implement OptionT as HK2 use tipealias for HKX * add missing methods
КТ-21795: check available kotlin version on backend side
* add deploy * minor improvement * bad indent * missing method * delete gradle from modules * fix missing module * increase decoding from raw threshold
use tipealias for HKX