Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Initial prism impl #258

Merged
merged 2 commits into from
Sep 7, 2017
Merged

Initial prism impl #258

merged 2 commits into from
Sep 7, 2017

Conversation

nomisRev
Copy link
Member

@nomisRev nomisRev commented Sep 5, 2017

Added initial prism impl with laws
Changed Pair -> Tuple2
Moved to package kategory.optics

@nomisRev
Initial prism impl
e4f4010 
Added initial prism impl with laws
Changed Pair -> Tuple2 
Moved to package kategory.optics
Merge remote-tracking branch 'origin/simon-prism' into simon-prism
@nomisRev nomisRev requested review from raulraja, pakoito and a team September 5, 2017 21:59
@codecov-io
Copy link

codecov-io commented Sep 5, 2017 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (master@0e77607). Click here to learn what that means.
The diff coverage is 82.35%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #258   +/-   ##
=========================================
  Coverage          ?   50.47%           
  Complexity        ?      257           
=========================================
  Files             ?      115           
  Lines             ?     2605           
  Branches          ?      295           
=========================================
  Hits              ?     1315           
  Misses            ?     1174           
  Partials          ?      116
Impacted Files Coverage Δ Complexity Δ
...ory-optics/src/main/kotlin/kategory/optics/Lens.kt 78.12% <100%> (ø) 6 <3> (?)
...ry-optics/src/main/kotlin/kategory/optics/Prism.kt 78.57% <78.57%> (ø) 10 <10> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0e77607...2048a8c. Read the comment docs.

raulraja
raulraja approved these changes Sep 7, 2017
View reviewed changes
Copy link
Member

@raulraja raulraja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏

@raulraja raulraja merged commit 751f25a into arrow-kt:master Sep 7, 2017
@wiyarmir wiyarmir mentioned this pull request Sep 15, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raulraja raulraja raulraja approved these changes

@pakoito pakoito Awaiting requested review from pakoito

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nomisRev @codecov-io @raulraja