Add wrapper class for Set #247
Conversation
Codecov Report
@@ Coverage Diff @@
## master #247 +/- ##
=========================================
Coverage ? 41.69%
Complexity ? 259
=========================================
Files ? 136
Lines ? 3149
Branches ? 410
=========================================
Hits ? 1313
Misses ? 1710
Partials ? 126
Continue to review full report at Codecov.
|
| package kategory | ||
|
|
||
| @higherkind | ||
| @deriving(Monad::class, Traverse::class, MonoidK::class) |
There was a problem hiding this comment.
Set can't have neither Monad nor Traverse instances. Just Foldable and MonoidK because sets don't guarantee order of iteration and that is why flatMap gives you back an Iterable. We should only have those two mentioned instances
| @deriving(Monad::class, Traverse::class, MonoidK::class) | ||
| data class SetKW<A>(val set: Set<A>) : SetKWKind<A>, Set<A> by set { | ||
|
|
||
| fun <B> flatMap(f: (A) -> SetKWKind<B>): SetKW<B> = this.set.flatMap { f(it).ev().set }.toSet().k() |
There was a problem hiding this comment.
🔥 remove as this would yield nondeterministic results.
| return Eval.defer { loop(this) } | ||
| } | ||
|
|
||
| fun <G, B> traverse(f: (A) -> HK<G, B>, GA: Applicative<G>): HK<G, SetKW<B>> = |
There was a problem hiding this comment.
🔥 remove as this would yield nondeterministic results.
|
|
||
| fun <B> flatMap(f: (A) -> SetKWKind<B>): SetKW<B> = this.set.flatMap { f(it).ev().set }.toSet().k() | ||
|
|
||
| fun <B> map(f: (A) -> B): SetKW<B> = this.set.map(f).toSet().k() |
| GA.map2Eval(f(a), eval) { (setOf(it.a) + it.b).k() } | ||
| }.value() | ||
|
|
||
| fun <B, Z> map2(fb: SetKWKind<B>, f: (Tuple2<A, B>) -> Z): SetKW<Z> = |
| } | ||
| } | ||
|
|
||
| fun <A, B> tailRecM(a: A, f: (A) -> HK<SetKWHK, Either<A, B>>): SetKW<B> { |
| return SetKW(buf.toSet()) | ||
| } | ||
|
|
||
| fun functor(): SetKWHKMonadInstance = SetKW.monad() |
|
|
||
| fun functor(): SetKWHKMonadInstance = SetKW.monad() | ||
|
|
||
| fun applicative(): SetKWHKMonadInstance = SetKW.monad() |
|
I've updated the PR with the comments :) |
| fun <B> foldR(lb: Eval<B>, f: (A, Eval<B>) -> Eval<B>): Eval<B> { | ||
| fun loop(fa_p: SetKW<A>): Eval<B> = when { | ||
| fa_p.set.isEmpty() -> lb | ||
| else -> f(fa_p.set.first(), Eval.defer { loop(fa_p.set.drop(1).toSet().k()) }) |
|
|
||
| @higherkind | ||
| @deriving(Foldable::class, MonoidK::class) | ||
| data class SetKW<A>(val set: Set<A>) : SetKWKind<A>, Set<A> by set { |
|
done @raulraja :D thanks for the help |
|
@victorg1991 can you remerge master, we changed the modules location |
|
Done @raulraja 👍 |
Addressing #203