MonadWriter #210
Merged
MonadWriter #210
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raulraja
approved these changes
Aug 17, 2017
| @@ -27,6 +27,8 @@ interface WriterTInstances<F, W> : | |||
|
|
|||
| } | |||
|
|
|||
| interface WriterTMonadWriter<F, W> : MonadWriter<WriterTKindPartial<F, W>, W> | |||
There was a problem hiding this comment.
Since this does not imposes new constrains I think it's fine to implement inline to be consistent how Functor, Applicative and Monad are implemented and there would be no need for the extra interface WriterTMonadWriter
Codecov Report
@@ Coverage Diff @@
## master #210 +/- ##
=======================================
Coverage ? 52%
Complexity ? 200
=======================================
Files ? 98
Lines ? 2123
Branches ? 261
=======================================
Hits ? 1104
Misses ? 911
Partials ? 108
Continue to review full report at Codecov.
|
rachelcarmena
added a commit
that referenced
this pull request
Feb 24, 2021
Co-authored-by: Jorge Castillo <[email protected]> Co-authored-by: Rachel M. Carmena <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #163
Disclaimer:
MonadWriterwas moved toFunctorListeninsidecats-mtlmodule. The reason to keep implementingMonadWriterhere is that I think we should definitely keep "old" constructs (the one valids until catspre-1.0.0) for the time being, until we have a first release. I would iterate towardskategory-mtlmodule with the same renaming / refactor iterations applied to cats probably after release, to avoid more noise.