Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add AsyncContext typeclass #192

Merged
merged 7 commits into from
Aug 13, 2017
Merged

Add AsyncContext typeclass #192

merged 7 commits into from
Aug 13, 2017

Conversation

pakoito
Copy link
Member

@pakoito pakoito commented Aug 13, 2017

This PR add AsyncContext based off Freestyle's. It includes a couple of constructor helpers to be used in comprehensions, along with basic laws.

@pakoito pakoito requested review from raulraja and a team August 13, 2017 19:16
@codecov-io
Copy link

codecov-io commented Aug 13, 2017

Codecov Report

❗ No coverage uploaded for pull request base (master@e3eb0fd). Click here to learn what that means.
The diff coverage is 50%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #192   +/-   ##
=========================================
  Coverage          ?   53.61%           
  Complexity        ?      201           
=========================================
  Files             ?       94           
  Lines             ?     1977           
  Branches          ?      235           
=========================================
  Hits              ?     1060           
  Misses            ?      816           
  Partials          ?      101
Impacted Files Coverage Δ Complexity Δ
...rc/main/kotlin/kategory/effects/typeclass/Async.kt 0% <0%> (ø) 0 <0> (?)
...n/kotlin/kategory/effects/instances/IOInstances.kt 61.53% <75%> (ø) 0 <0> (?)
...ffects/src/main/kotlin/kategory/effects/data/IO.kt 72.63% <83.33%> (ø) 10 <0> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e3eb0fd...2f26284. Read the comment docs.

Copy link
Member

@raulraja raulraja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💥 :shipit:

@raulraja raulraja merged commit 755a6b3 into master Aug 13, 2017
@raulraja raulraja deleted the paco-async branch August 13, 2017 19:23
@pakoito pakoito mentioned this pull request Aug 14, 2017
54 tasks
rachelcarmena pushed a commit that referenced this pull request Feb 24, 2021
* Make some more functions inline with crossinline lambdas

* Deprecate Validated.leftMap in favour of mapLeft

* Deprecate Either.catch(fe, f) in favour catch(f).mapLeft(fe)

* Add missing tests to Either.catch

* Workaround a possible false positive from animal sniffer

Co-authored-by: Simon Vergauwen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants